feat(aria-snapshot): add numberSubstitution option for baseline generation#40977
Closed
adityasingh2400 wants to merge 1 commit into
Closed
Conversation
…ation Closes microsoft#40080. The aria-snapshot baseline generator currently rewrites numbers and dates into \d+ regexes, which is helpful for live UIs but unwanted for tests against mocked endpoints where the values are stable. This adds a numberSubstitution: 'regex' | 'static' option (default 'regex' so existing baselines do not change) that can be set per matcher or globally via the expect config.
Skn0tt
reviewed
May 26, 2026
| // To generate aria assertion with regex heuristics. The numberSubstitution | ||
| // option (default 'regex') lets callers opt out of auto-converting numbers | ||
| // and dates into \d+ regexes when the baseline values are stable. | ||
| const renderStringsAsRegex = options.numberSubstitution !== 'static'; |
Member
There was a problem hiding this comment.
This turns of regex substitution for all heuristics even if the user only asked about one heuristic.
Member
|
This API shape isn't a good fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40080.
The aria-snapshot baseline generator currently rewrites numbers and dates into
\d+regexes, which is helpful for live UIs but unwanted for tests against mocked endpoints where the values are stable. This adds anumberSubstitution: 'regex' | 'static'option (default'regex'so existing baselines do not change) that can be set per matcher call or globally via theexpect.toMatchAriaSnapshotconfig.Usage:
The option is plumbed through
expressionArgon the existingto.match.ariachannel, then read insidematchesExpectAriaTemplateto gate the regex-rewrite step inrenderAriaTree's codegen mode.Tests cover both modes plus the existing default behavior, including the precedence where a per-call option overrides the global config.